Skip to content

Conversation

@304NotModified
Copy link
Member

When reqnroll/Reqnroll#538 is merged

@304NotModified 304NotModified changed the title Added xunit3 Add xunit3 Aug 25, 2025
@clrudolphi
Copy link
Contributor

clrudolphi commented Sep 23, 2025

@304NotModified #538 got merged.
I'm confused though, as I've checked out this branch, built, and launched the experimental instance to create a new project. While it shows xunit3 as a selection option, when it creates the project there are no dependencies resolved other than the MS Test SDK. I get that Reqnroll couldn't be resolved (the plugin hasn't been released yet to nuget), but I would have expected it to resolve xUnit.v3. What am I missing?

SOLVED: the template was using an incorrect value for the $if$ statement.

….v3 is selected.

Updated Reqnroll plugin references to v3.1.0
@clrudolphi clrudolphi marked this pull request as ready for review September 26, 2025 14:36
Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. Could you please add an entry to the CHANGELOG?

@clrudolphi
Copy link
Contributor

@gasparnagy Build is failing on gh related to an assembly load problem. This same test passes on my machine.
I'm not familiar with the connector tests.
Would you mind pointing me in the right direction?

@gasparnagy
Copy link
Contributor

@gasparnagy Build is failing on gh related to an assembly load problem. This same test passes on my machine. I'm not familiar with the connector tests. Would you mind pointing me in the right direction?

I will, but please allow me a bit of time for it. This week is very busy.

@clrudolphi
Copy link
Contributor

@gasparnagy Build is failing on gh related to an assembly load problem. This same test passes on my machine. I'm not familiar with the connector tests. Would you mind pointing me in the right direction?

I will, but please allow me a bit of time for it. This week is very busy.

Same issue on #121.

@gasparnagy
Copy link
Contributor

@clrudolphi #124 will help. Please review and merge that, so that these will start working hopefully.

@clrudolphi
Copy link
Contributor

@clrudolphi #124 will help. Please review and merge that, so that these will start working hopefully.

Certainly. It appears that in that PR you had requested a review by ChrisGlew. Would you prefer I wait for his review before merging?

@gasparnagy
Copy link
Contributor

@clrudolphi #124 will help. Please review and merge that, so that these will start working hopefully.

Certainly. It appears that in that PR you had requested a review by ChrisGlew. Would you prefer I wait for his review before merging?

I haven't requested that, that's just what GH suggests. The UI of the reviewers is pretty bad. I have requested it from you explicitly now.

@clrudolphi
Copy link
Contributor

Now that #124 has been merged this is still failing. The failing Spec seems to be dynamically picking up the latest version of MsTest to use and MSTestv4 has breaking changes.

@gasparnagy gasparnagy merged commit 8eff7d9 into main Oct 21, 2025
2 checks passed
@gasparnagy gasparnagy deleted the revert-118-remove-xunit3 branch October 21, 2025 19:43
@gasparnagy
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants